chore: update @types/sinon and sinon#464
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdated Sinon version references: bumped the dev dependency for ChangesSinon type & manifest updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 29 29
Lines 1421 1421
Branches 191 191
=======================================
Hits 1365 1365
Misses 43 43
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
denops/@denops-private/cli_test.ts(1 hunks)denops/@denops-private/worker_test.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: test (windows-latest, 2.3.0, v9.1.1646, v0.11.3)
- GitHub Check: test (ubuntu-latest, 2.3.0, v9.1.1646, v0.11.3)
- GitHub Check: test (ubuntu-latest, 2.x, v9.1.1646, v0.11.3)
- GitHub Check: test (macos-latest, 2.x, v9.1.1646, v0.11.3)
- GitHub Check: test (macos-latest, 2.3.0, v9.1.1646, v0.11.3)
- GitHub Check: test (windows-latest, 2.x, v9.1.1646, v0.11.3)
🔇 Additional comments (1)
denops/@denops-private/worker_test.ts (1)
1-1: Remove the non-existent @types/sinon@^20.0.0 reference.The latest available version of @types/sinon is 17.0.4, not @types/sinon@^20.0.0. The deno-types directive in both
worker_test.tsandcli_test.tsreferences a non-existent npm package version. Since the root configuration already specifiessinon@^21.0.0as the runtime, you should either:
- Update the deno-types directive to use the actual latest version:
// @deno-types="npm:@types/sinon@^17.0.4"- Or remove the directive if Sinon v21 provides built-in type definitions
The version mismatch will cause type resolution failures at runtime.
Likely an incorrect or invalid review comment.
| @@ -1,5 +1,5 @@ | |||
| // NOTE: Use sinon to stub the getter property. | |||
| // @deno-types="npm:@types/sinon@^17.0.3" | |||
| // @deno-types="npm:@types/sinon@^20.0.0" | |||
There was a problem hiding this comment.
🧩 Analysis chain
LGTM! Verify compatibility with the major version bump.
The type definition update is consistent with the PR objective and aligns with the change in worker_test.ts. However, this is a major version bump (^17.0.3 → ^20.0.0), which may include breaking changes in type definitions.
Run the following script to verify the tests pass and check if dependency configuration files need updating:
🏁 Script executed:
#!/bin/bash
# Description: Run the CLI tests and check for dependency configuration
# Execute the test file
deno test denops/@denops-private/cli_test.ts
echo "---"
echo "Checking for dependency configuration files:"
# Check if deno.json or deno.jsonc exists and contains sinon references
if fd -t f '^deno\.jsonc?$' --max-depth 2 --exec cat {}; then
echo "Found deno.json/deno.jsonc"
fi
# Check for import_map.json
if fd -t f '^import_map\.json$' --max-depth 2 --exec cat {}; then
echo "Found import_map.json"
fiLength of output: 1589
Let me search for the other test file and verify the version compatibility:
🏁 Script executed:
#!/bin/bash
# Verify type annotation versions in both test files and check for mismatches
# Look for both cli_test.ts and worker_test.ts
echo "=== Searching for test files with @deno-types annotation ==="
rg -n '@deno-types' denops/ tests/ --type typescript
echo ""
echo "=== Checking cli_test.ts content ==="
fd -t f 'cli_test\.ts$' --exec cat {}
echo ""
echo "=== Checking worker_test.ts content (first 50 lines) ==="
fd -t f 'worker_test\.ts$' --exec head -50 {}Length of output: 20304
Critical version incompatibility detected—@types/sinon version does not exist.
The review comment approves the type definition update to @types/sinon@^20.0.0, but this version does not appear to exist in the npm registry. The latest version of @types/sinon is 17.0.4, and there are no published versions 20 or 21.
Additionally, there is a version mismatch between:
deno.json:"sinon": "npm:sinon@^21.0.0"cli_test.ts&worker_test.ts:@types/sinon@^20.0.0
This type definition update will fail at runtime. The correct version should align with the sinon package version in deno.json or use an actually-published version like @types/sinon@^17.0.0.
🤖 Prompt for AI Agents
In denops/@denops-private/cli_test.ts around line 2, the @deno-types annotation
references a non-existent @types/sinon@^20.0.0 which will fail at runtime;
update the @deno-types to a published version that matches the sinon entry in
deno.json (either change this line and the same one in worker_test.ts to
@types/sinon@^17.0.0 or alternatively update deno.json to use a sinon version
that has matching @types available) and ensure both test files and deno.json use
the same compatible sinon/@types version.
lambdalisue
changed the title
lambdalisue
force-pushed
the
automation/update-dependencies
branch
from
74deba3 to
f064656
Compare
lambdalisue
force-pushed
the
automation/update-dependencies
branch
from
f064656 to
6f5e153
Compare
lambdalisue
force-pushed
the
automation/update-dependencies
branch
from
6f5e153 to
6aa40a0
Compare
lambdalisue
changed the title
1 participant
📦 @types/sinon ^17.0.3 → ^21.0.0
📦 sinon ^21.0.0 → ^22.0.0